dotnet/msbuild

Consider blocking TaskLoggingHelper use after its task ends

Open

#4,828 opened on 2019年10月17日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)C# (1,364 forks)batch import
Area: Debuggabilityhelp wantedtriaged

Repository metrics

Stars
 (5,062 stars)
PR merge metrics
 (平均マージ 11d 7h) (30d で 125 merged PRs)

説明

see https://github.com/microsoft/msbuild/issues/4792#issuecomment-543336926 and the rest of that thread

If you hold onto a TaskLoggingHelper object (perhaps in a static field) past the lifetime of the Task that created it, it will throw when it is used.

We could instead dispose of it and provide a nicer error at time of use.

コントリビューターガイド