dotnet/msbuild

Remove conditional-evaluation-order warning

Open

#1,698 opened on 2017年2月14日

GitHub で見る
 (10 comments) (6 reactions) (0 assignees)C# (5,062 stars) (1,364 forks)batch import
Area: Languagehelp wantedtriaged

説明

The warning

MSB4130: The condition "{0}" may have been evaluated incorrectly in an earlier version of MSBuild. Please verify that the order of the AND and OR clauses is written as intended. To avoid this warning, add parentheses to make the evaluation order explicit.

is emitted whenever a condition has an and and an or in parallel, for example X and Y or Z.

Looking through ancient history, it appears to have been introduced in MSBuild 3.5 in 2007, because a bug in MSBuild 2.0 that caused unexpected evaluation order was fixed then.

It feels wrong to emit an informational-only warning about a behavior change that happened 10 years ago.

Eliminating the check for this warning would allow pruning a tree of methods that exist only to provide it. They're currently in the code in REMOVE_COMPAT_WARNING regions. I propose to do just what that implies.

コントリビューターガイド

技術スタック
csharp
領域
build systemtooling
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C#MSBuild condition evaluation
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
50
調査方針
Look for REMOVE COMPAT WARNING regions in the MSBuild codebase that contain methods related to conditional evaluation order warnings. The main warning string is 'MSB4130'. Investigate the methods that can be pruned after removing the check. The issue suggests eliminating the check entirely, which will allow removal of the entire tree of methods that exist only to provide that warning.