dotnet/msbuild

Better diagnostic logging in RAR when marking CopyLocal=false

Open

#1,485 opened on 2016年12月15日

GitHub で見る
 (1 comment) (4 reactions) (0 assignees)C# (5,062 stars) (1,364 forks)batch import
Area: DebuggabilityArea: LoggingArea: Task: Resolve Assembly References (RAR)User Experiencehelp wantedtriaged

説明

Sometimes it is very difficult to understand why some transitive dependencies are copied to the output directory while others aren't.

It would greatly help to improve logging in this code: https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/AssemblyDependency/Reference.cs#L1226-L1247

Specifically, we already list all source items in the log: https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/AssemblyDependency/ResolveAssemblyReference.cs#L1645 It would be nice to also print their Private metadata if present.

This way we can know which one specified their Private=false and let to exclusion. Otherwise we have to double-check in the log elsewhere what the metadata was. It's possible but hard to use.

コントリビューターガイド

技術スタック
csharp
領域
build systemtooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C#MSBuild internals
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
60
調査方針
The issue requests improved diagnostic logging in MSBuild's ResolveAssemblyReference task. Specifically, when marking CopyLocal=false, the logging should print the Private metadata of source items to help understand why transitive dependencies are excluded. The code to modify is in Reference.cs lines 1226-1247 and ResolveAssemblyReference.cs line 1645. The goal is to add logging of Private metadata when present, without changing behavior. Look at the linked code and add appropriate diagnostic messages.