dotnet/msbuild

[Feature Request]: Reduce the wrapping around SDK Resolver messages when only one resolver is actually invoked

Open

#10,191 opened on 2024年5月30日

GitHub で見る
 (4 comments) (1 reaction) (0 assignees)C# (5,062 stars) (1,364 forks)batch import
Area: LoggingArea: ResolversFeature RequestGood First IssuePriority:2internal-team-onboardingtriaged

説明

Summary

In https://github.com/dotnet/sdk/pull/41268 I was able to use the SDK Resolver features to ensure that only the NuGet SDK resolver was used for a restore. In this case we should be able to remove MSBuild wrapping around the 'error list' and only surface the single Resolver's message.

Background and Motivation

We want to remove visual noise around error experiences and make it easier for users to diagnose the core problems.

Proposed Feature

https://github.com/dotnet/msbuild/blob/003252215533cca375dfc6578d8cb9e029418f37/src/Build/BackEnd/Components/SdkResolution/SdkResolverService.cs#L277-L280 should change the way it logs to not log the wrapper if only one resolver was used.

Alternative Designs

No response

コントリビューターガイド

技術スタック
csharp
領域
build systemdeveloper experience
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
active
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C#MSBuild build systemSDK resolver
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
Examine the referenced code in SdkResolverService.cs around line 277-280 to understand the current wrapping logic. Review the linked SDK PR #41268 to see how the single resolver condition is detected. Propose a change to conditionally log the wrapper only when multiple resolvers were used. Ensure the change maintains backward compatibility and includes appropriate tests.