dotnet/aspnetcore
GitHub で見るNotifyOnCompleted does not catch exceptions, may abort the response/connection
Open
#5,885 opened on 2018年3月7日
affected-very-fewarea-networkingbugfeature-httpsyshelp wantedseverity-nice-to-have
Repository metrics
- Stars
- (37,933 stars)
- PR merge metrics
- (平均マージ 16d 9h) (30d で 258 merged PRs)
説明
NotifyOnCompleted should catch and log its own exceptions as to not disrupt the normal request flow. It doesn't.
https://github.com/aspnet/HttpSysServer/blob/336e85d19abcdf3ec3a024cb9431c768a4e5d494/src/Microsoft.AspNetCore.Server.HttpSys/MessagePump.cs#L204-L214 https://github.com/aspnet/HttpSysServer/blob/336e85d19abcdf3ec3a024cb9431c768a4e5d494/src/Microsoft.AspNetCore.Server.HttpSys/FeatureContext.cs#L586-L591
It also fires before the response is flushed/disposed so these exceptions may abort the response/connection. Compare to https://github.com/aspnet/KestrelHttpServer/pull/2324