dotnet/aspnetcore

Short circuit attribute

クローズ

#49,181 opened on 2023/07/03

 (12 件のコメント) (2 件のリアクション) (1 人の担当者)C# (10,653 件のフォーク)batch import
api-approvedarea-middlewarehelp wanted

Repository metrics

Stars
 (37,933 個のスター)
PR merge metrics
 (平均マージ 16d 9h) (30d で 258 merged PRs)

説明

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

The short circuit feature only has extension methods for adding the required metadata to endpoints. Should there be an attribute? That would allow MVC actions and gRPC methods to support short circuiting.

For example,

public class MonitoringController
{
    [ShortCircuit]
    [HttpGet("/status")]
    public ActionResult GetStatus()
    {
        // ...
    }
}

Brought up in YouTube video: https://youtu.be/rXdwX2X4-gw?t=422

Note that a short-circuited MVC action would still execute filters, and a gRPC method would still execute interceptors.

Describe the solution you'd like

  • Change internal ShortCircuitMetadata to an interface. (optional)
  • Change current metadata to an attribute and make public (implement the interface if present)

Additional context

No response

コントリビューターガイド