dotnet/aspnetcore

Write more content directly to StreamWriter in W3CLogger

オープン

#33,946 opened on 2021/06/29

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)C# (10,653 件のフォーク)batch import
Perfarea-networkinghelp wanted

Repository metrics

Stars
 (37,933 個のスター)
PR merge metrics
 (PR metrics pending)

説明

See https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r655734742, https://github.com/dotnet/aspnetcore/pull/33251/#discussion_r656445769.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLogger.cs#L49

Since we know the only consumer of this data is StreamWriter, can you delay the Format, enqueue the elements array, and format when writing to the stream? This intermediate string is likely large and useless.

https://github.com/dotnet/aspnetcore/blob/3177376dca6ca0a6bba1d4ab946e77f02547c167/src/Middleware/HttpLogging/src/W3CLoggerProcessor.cs#L35

More content that should be written directly to the streamWriter.

コントリビューターガイド