dotnet/aspnetcore

HttpRuleParser GetExpressionLength allows invalid characters.

オープン

#2,694 opened on 2018/01/02

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)C# (10,653 件のフォーク)batch import
affected-fewarea-networkingbugfeature-http-abstractionshelp wantedseverity-minor

Repository metrics

Stars
 (37,933 個のスター)
PR merge metrics
 (PR metrics pending)

説明

From @jkotalik on Tuesday, August 22, 2017 4:19:40 PM

@Tratcher and I discovered that GetExpressionLength in HttpRuleParser allows invalid characters (including control characters in expressions. GetExpressionLength mentions that we don't really care about the content of a quoted string, however it seems appropriate that if a quoted string has an invalid character, it should throw on parsing here, not in Kestrel (or whatever server).

This would be a breaking change, as it would introduce a new place where an exception is thrown, however it is probably the right behavior.

Copied from original issue: aspnet/HttpAbstractions#923

コントリビューターガイド