dotnet/aspnetcore

LoadAsync on Session - when _isNewSessionKey is true

オープン

#20,898 opened on 2020/04/16

 (10 件のコメント) (0 件のリアクション) (0 人の担当者)C# (10,653 件のフォーク)batch import
Perfaffected-fewarea-middlewarebreaking-changeenhancementhelp wantedseverity-nice-to-have

Repository metrics

Stars
 (37,933 個のスター)
PR merge metrics
 (PR metrics pending)

説明

https://github.com/dotnet/aspnetcore/blob/8b000d961cd3ccfcc8090fb8368fd6598bace978/src/Middleware/Session/src/DistributedSession.cs

Should Load/LoadAsync be a no-op when _isNewSessionKey is true. Taking the advice to call LoadAsync prior to accessing the session with get/trygetvalue/set I would of thought we'd guard against unnecsssary chitchat to the cache if we know the session is new?

I though about doing Request.Cookies["sesscoookie"] != null then await LoadAsync but then doing Get/Set/Id/IsAvailable will simply call load anyway if not _loaded isnt marked.

コントリビューターガイド