dotansimha/graphql-code-generator

Add return type to function to avoid eslint warning explicit-module-boundary-types

Open

#5,348 opened on 2021年1月3日

GitHub で見る
 (0 comments) (13 reactions) (0 assignees)TypeScript (10,341 stars) (1,295 forks)batch import
corehelp wantedkind/enhancementplugins

説明

I'm using strict typescript and I want all functions to explicitly define their return types. However, when generating the types using code generator, the function have no return type.

Of course I can disabled eslint for the file (/* eslint-disable @typescript-eslint/explicit-module-boundary-types */), but this is messy

Example ;

export function useFindRefBudgetEntityQuery(
	baseOptions?: Apollo.QueryHookOptions<
		FindRefBudgetEntityQuery,
		FindRefBudgetEntityQueryVariables
	>
) {
	return Apollo.useQuery<
		FindRefBudgetEntityQuery,
		FindRefBudgetEntityQueryVariables
	>(FindRefBudgetEntityDocument, baseOptions);
}

the returnType is compiled but not set to this function

export type FindRefBudgetEntityQueryResult = Apollo.QueryResult<
	FindRefBudgetEntityQuery,
	FindRefBudgetEntityQueryVariables
>;

adding it works fine

export function useFindRefBudgetEntityQuery(
	baseOptions?: Apollo.QueryHookOptions<
		FindRefBudgetEntityQuery,
		FindRefBudgetEntityQueryVariables
	>
):Apollo.QueryResult<
FindRefBudgetEntityQuery,
FindRefBudgetEntityQueryVariables
> {
	return Apollo.useQuery<
		FindRefBudgetEntityQuery,
		FindRefBudgetEntityQueryVariables
	>(FindRefBudgetEntityDocument, baseOptions);
}

コントリビューターガイド

Add return type to function to avoid eslint warning explicit-module-boundary-types · dotansimha/graphql-code-generator#5348 | Good First Issue