dlt-hub/dlt

make the use of `loader_file_format` parameter consistent

オープン

#815 opened on 2023/12/11

 (4 件のコメント) (0 件のリアクション) (0 人の担当者)Python (589 件のフォーク)github user discovery
QoLgood first issue

Repository metrics

Stars
 (5,765 個のスター)
PR merge metrics
 (平均マージ 7d 7h) (30d で 54 merged PRs)

説明

Background The loader_file_format can be configured on the pipeline level and this is fine. But technically it is a normalize setting and we should be able to configure it there as well.

Also not all data types are supported by all formats on all destinations. We should detect those and fail early.

Tasks

    • add loader_file_format to normalize configuration and use it to set the file format. If the explicit value is passed from the pipeline, it has the precedence.
    • add the exceptions to destination capabilities where we declare unsupported types per file format. Take the current cases from particular destination code (ie Bigquery and Snowflake have plenty of exceptions)
    • detect such exceptions in normalize (preferably in worker: before updating a schema check if any type is on exception list and raise exception with an explanation)
    • the behavior above must be tested

コントリビューターガイド