djenriquez/vault-ui

Confirmation of secret change - Feature request

Open

#101 opened on 2017年4月24日

GitHub で見る
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,306 stars) (159 forks)batch import
feature requesthelp wanted

説明

First off, great job! I really appreciate the work. Would it be possible to add a confirmation when changing a secret? It seems too easy to accidentally overwrite a secret. This might be more my use case than others, but I have a lot secrets that just get read and I want to avoid them being inadvertently changed when a user is copy/pasting them.

Two ideas:

  1. Just a simple confirmation box before saving
  2. Have the secrets displayed in a modal, non-editable mode which requires clicking an edit button to make changes.

コントリビューターガイド

技術スタック
javascriptreact
領域
frontendsecurity
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
なし
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
85
調査方針
The feature request proposes adding a confirmation step before saving a secret to prevent accidental overwrites. Two approaches are suggested: a simple confirmation dialog or a modal with an edit button. To implement, examine the current secret creation/editing workflow, likely in a React component such as SecretForm.js or similar. Adding a state variable for editing mode and a confirmation modal component would achieve this. The existing UI patterns for modals in the project can be reused.
Confirmation of secret change - Feature request · djenriquez/vault-ui#101 | Good First Issue