diasurgical/DevilutionX

Refactor devilution.DefaultClass::CheckInvPaste(int, int, int)

オープン

#1,996 opened on 2021/05/17

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)C++ (743 件のフォーク)batch import
good first issuehelp wanted

Repository metrics

Stars
 (7,255 個のスター)
PR merge metrics
 (平均マージ 2d 12h) (30d で 15 merged PRs)

説明

I've selected devilution.DefaultClass::CheckInvPaste(int, int, int) for refactoring, which is a unit of 362 lines of code and 135 branch points. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Simple Units of Code guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖 Limit the number of branch points (if, for, while, etc.) per unit to 4.
  • Why❓ Keeping the number of branch points low makes units easier to modify and test.
  • How 🔧 Split complex units with a high number of branch points into smaller and simpler ones. This one in particular has a big switch that could probably be split out in to sub-functions.

You can find more info about this guideline in Building Maintainable Software. 📖


Good luck and happy coding! :shipit: :sparkles: :100:

コントリビューターガイド