diasurgical/DevilutionX

Refactor devilution.DefaultClass::CheckCursMove()

オープン

#1,995 opened on 2021/05/17

 (2 件のコメント) (0 件のリアクション) (0 人の担当者)C++ (743 件のフォーク)batch import
good first issuehelp wanted

Repository metrics

Stars
 (7,255 個のスター)
PR merge metrics
 (平均マージ 2d 12h) (30d で 15 merged PRs)

説明

I've selected devilution.DefaultClass::CheckCursMove() for refactoring, which is a unit of 421 lines of code. Addressing this will make our codebase more maintainable and improve Better Code Hub's Write Short Units of Code guideline rating! 👍

Here's the gist of this guideline:

  • Definition 📖 Limit the length of code units to 15 lines of code.
  • Why❓ Small units are easier to analyse, test and reuse.
  • How 🔧 When writing new units, don't let them grow above 15 lines of code. When a unit grows beyond this, split it in smaller units of no longer than 15 lines.

You can find more info about this guideline in Building Maintainable Software. 📖


Good luck and happy coding! :shipit: :sparkles: :100:

コントリビューターガイド