decentralized-identity/ion
GitHub で見るBitcoinClient should check for if the 'bitcoinWalletOrImportString' parameter is undefined
Open
#314 opened on 2020年4月20日
good first issue
Repository metrics
- Stars
- (1,219 stars)
- PR merge metrics
- (30d に merged PR はありません)
説明
If the admin forgets to add in either the import string or an actual IBitcoinWallet on this parameter then we should throw here. Currently, the this.bitcoinWallet member stays undefined and we throw when we try to use it.
Suggestion:
if (typeof bitcoinWalletOrImportString === 'undefined') { // throw }
// OR
// After all the initializations
if (this.bitcoinWallet === undefined) { // throw }