davidtheclark/no-scroll

Previous styles on documentElement are not restored

Open

#10 opened on 2019年1月2日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)HTML (13 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (244 stars)
PR merge metrics
 (PR metrics pending)

説明

I had a use case where the documentElement had inline styles on it, like so: <html style="padding: 0; margin: 0; overflow-x=hidden;">. I noticed that after toggling no-scroll to off, the overflow-x=hidden was being wiped out. After checking the code in no-scroll, I found that it's hard-coding the style attributes when off() is called. I think that no-scroll should be restoring whatever values were set before on() was called, instead of overwriting them.

コントリビューターガイド