danger/danger

Danger inline commenting doesn't seem to work with space in path

オープン

#1,042 opened on 2018/11/27

 (11 件のコメント) (0 件のリアクション) (0 人の担当者)Ruby (491 件のフォーク)batch import
GitHubHelp WantedYou Can Do This

Repository metrics

Stars
 (5,297 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Report

What did you do?

I'm using danger-ruby-swiftlint, using inline_mode which just dispatches the warn/fail messages to danger with the file path. It seems, though, that if the path contains a space, the message isn't dispatched as inline, but fall-backs to a regular comment.

I've opened an issue on that repo, but after digging a bit I feel quite confident the issue is inside danger:

Unfortunately as much as I've tried, I don't have enough Ruby knowledge, or danger-specific knowledge, to understand where and how to start debugging this.

Working example: image

Test where filename has space just fall-backs into a regular warning: image

What did you expect to happen?

All inline comments are posted inline with the provided file path.

What happened instead?

If a file path has a space, instead of inline comment, it falls back to regular comment:

Your Environment

  • Which CI are you running on? Bitrise
  • Are you running the latest version of Danger? Yes
  • What is your Dangerfile? for the case of this just swiftlint.lint with inline mode.

コントリビューターガイド