Danger inline commenting doesn't seem to work with space in path
#1,042 opened on 2018年11月27日
Repository metrics
- Stars
- (5,297 stars)
- PR merge metrics
- (平均マージ 60d 8h) (30d で 5 merged PRs)
説明
Report
What did you do?
I'm using danger-ruby-swiftlint, using inline_mode which just dispatches the warn/fail messages to danger with the file path. It seems, though, that if the path contains a space, the message isn't dispatched as inline, but fall-backs to a regular comment.
I've opened an issue on that repo, but after digging a bit I feel quite confident the issue is inside danger:
Unfortunately as much as I've tried, I don't have enough Ruby knowledge, or danger-specific knowledge, to understand where and how to start debugging this.
Working example:

Test where filename has space just fall-backs into a regular warning:

What did you expect to happen?
All inline comments are posted inline with the provided file path.
What happened instead?
If a file path has a space, instead of inline comment, it falls back to regular comment:
Your Environment
- Which CI are you running on? Bitrise
- Are you running the latest version of Danger? Yes
- What is your Dangerfile? for the case of this just
swiftlint.lintwith inline mode.