Pre-aggregations with elasticsearch as datasource are not timezone aware · cube-js/cube#7700

(2 comments) (0 reactions) (0 assignees)Rust (19,563 stars) (1,965 forks)batch import

driver:elasticsearchhelp wanted

説明

When creating pre-aggregations with different time zones and elasticsearch as a data source, the time dimension of the results is not converted to each applicable time zone because 'convertTz' is not implemented in the "ElasticSearchQuery" adapter. The convertTz function code can be as follows:

public convertTz(field: string): string {
    const tz = moment().tz(this.timezone);
    // TODO respect day light saving
    const [hour, minute] = tz.format('Z').split(':');
    const [hourInt, minuteInt] = [parseInt(hour, 10), parseInt(minute, 10) * Math.sign(parseInt(hour, 10))];
    let result = field;
    if (hourInt !== 0) {
      result = `TIMESTAMPADD('hour', ${hourInt}, ${result})`;
    }
    if (minuteInt !== 0) {
      result = `TIMESTAMPADD('minute', ${minuteInt}, ${result})`;
    }
    return result;
}

コントリビューターガイド

技術スタック: javascripttypescriptnodejselasticsearch
領域: backenddatabase
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: fresh
明確さ: mostly clear
前提条件: JavaScriptElasticsearch query syntaxmoment.js
初心者向け度: 60
調査方針: The issue involves implementing the convertTz function in the ElasticSearchQuery adapter. Locate the adapter file (likely in packages/cubejs elasticsearch driver/src/ElasticSearchQuery.ts). Follow the pattern from other adapters' convertTz implementations, using moment.js to apply timezone offset via TIMESTAMPADD. Ensure daylight saving time is handled and the function integrates with existing pre aggregation logic. No existing PRs; the maintainers have not clarified scope, so the implementation should be straightforward.