cssinjs/jss

Throw Error instead of warning when running tests

Open

#891 opened on 2018年10月14日

GitHub で見る
 (6 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
help wantedideaimportant

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

I see in the logs many warnings, which I think shouldn't be there, which means we are ignoring problems without noticing in the CI.

I am wondering if we should replace the warning when running tests with a function that throws errors so that our tests can't ignore them.

As a bonus we won't ned to rewire in so many places, but instead use expect for catching.

コントリビューターガイド