cssinjs/jss

Issue with SheetRegistry.toString({format: false}) minifyer - part of the css is not minified

Open

#1,566 opened on 2021年10月19日

GitHub で見る
 (9 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import
bugcomplexity:lowhelp wantedneeds reproductionneeds tests

説明

Expected behavior: Minify all the server-side CSS.

Describe the bug: Font faces and CSS variables are not getting minified In Next.js app.

Reproduction: Create CSS file with CSS variables and font faces, and get the registry string with Registry.toString({format: false})

Versions (please complete the following information):

  • react-jss: 10.8.0
  • Browser [e.g. chrome, safari]: chrome
  • OS [e.g. Windows, macOS]: macOS Feel free to add any additional versions which you may think are relevant to the bug.

Managing expectations:

Maintainers will not be fixing the problem you have unless they have it too, if you want it to get fixed:

  1. Submit a PR with a failing test
  2. Discuss a solution
  3. Implement it

You can also do the first step only and wait for someone else to work on a fix. Anything is much better than nothing.

コントリビューターガイド

技術スタック
javascriptreactnodejsnextjs
領域
frontendbackend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
JavaScriptReactCSS
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the `SheetRegistry.toString` method in the JSS codebase, specifically the minification logic that handles CSS variables and font faces. Look for a minifier plugin or custom CSS processing that might be skipping these patterns. The issue suggests submitting a failing test first, so writing a test that reproduces the bug in a Next.js environment would be a good starting point. Check the existing test suites for similar integration tests.