cssinjs/jss

Styles created multiple times when using function values

オープン

#1,361 opened on 2020/07/03

 (8 件のコメント) (6 件のリアクション) (0 人の担当者)JavaScript (434 件のフォーク)batch import
bughelp wantedimportantperf

Repository metrics

Stars
 (7,000 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Expected behavior: Duplicate styles shouldn't be created.

Describe the bug: On every component render, in which useStyles prop changes, new duplicate styles are created. I've managed to reproduce the bug in Codesandbox. To see it:

  1. Open codesandbox link from below
  2. Inspect red text element and see styles applied
  3. Click on button few times to cause component re-render
  4. Inspect some another element on the page and the red text again.
  5. Notice duplicate styles The styles are duplicated only for elements styled with css selector. If you check styles on the element with container class, you'll see there is no duplication there.

Codesandbox link: https://codesandbox.io/s/react-jss-playground-7ftrs?file=/index.js

Versions (please complete the following information):

  • jss: 10.1.1
  • Browser [e.g. chrome, safari]: any
  • OS [e.g. Windows, macOS]: any

コントリビューターガイド