cssinjs/jss

react-jss: Observables issue

Open

#1,193 opened on 2019年9月17日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)JavaScript (434 forks)batch import
bughelp wanted

Repository metrics

Stars
 (7,000 stars)
PR merge metrics
 (30d に merged PR はありません)

説明

Expected behavior: Observables should not change the {link: true} to {link: false}

Describe the bug: If Observable's internal method is enumerable, then react-jss considers it a dynamic style and adds an unnecessary empty class. On the other hand, if the method is not enumerable, then the empty class is not added, but it does not link the styles and observable styles do not work.

Codesandbox link: https://codesandbox.io/s/react-jss-v1000alpha-25-observable-issue-g8998

Versions (please complete the following information):

  • jss: 10.0.0-alpha.25
  • Browser [e.g. chrome, safari]: Chrome
  • OS [e.g. Windows, macOS]: Windows

コントリビューターガイド