react-jss: Observables issue · cssinjs/jss#1193

(0 comments) (0 reactions) (0 assignees)JavaScript (7,000 stars) (434 forks)batch import

bughelp wanted

説明

Expected behavior: Observables should not change the {link: true} to {link: false}

Describe the bug: If Observable's internal method is enumerable, then react-jss considers it a dynamic style and adds an unnecessary empty class. On the other hand, if the method is not enumerable, then the empty class is not added, but it does not link the styles and observable styles do not work.

Codesandbox link: https://codesandbox.io/s/react-jss-v1000alpha-25-observable-issue-g8998

Versions (please complete the following information):

jss: 10.0.0-alpha.25
Browser [e.g. chrome, safari]: Chrome
OS [e.g. Windows, macOS]: Windows

コントリビューターガイド

技術スタック: javascriptreact
領域: frontend
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: ReactJSSObservables
初心者向け度: 40
調査方針: Investigate the interaction between react jss and observable objects. Examine the code in react jss that detects dynamic styles (likely in `useStyles` or style observation logic). The issue mentions that if observable's internal method is enumerable, an unnecessary empty class is added; if not enumerable, styles are not linked. The linked CodeSandbox should be used to reproduce. A possible fix could involve checking for observable objects differently, perhaps by using a weak map or not relying on enumerability.