crytic/slither

Improve test_ast_parsing.py

Open

#681 opened on 2020年11月10日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)Python (886 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,769 stars)
PR merge metrics
 (平均マージ 54d 9h) (30d で 2 merged PRs)

説明

One issue with our current parsing pytest is that it is not robust against new version of solc for the xfail tests. For example, these tests are not working with 0.7.1 and 0.7.2: https://github.com/crytic/slither/blob/ae7c410938b616d993e6c27678f6e48d9a4d7dd6/tests/test_ast_parsing.py#L81-L82

And was not updated when 0.7.3/0.7.4 were released. So the tests fail, while the script should have expected to not support 0.7.3 and 0.7.4 for this test.

We should have two version of XFAIL: the ones that fail for a specific version, and the ones that fail from a version

コントリビューターガイド