coreybutler/nvm-windows

[Bug/Feature?]: pnpm leaves files in nodejs install dir, breaking nvm install

Open

#1,093 opened on 2024年1月18日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Go (46,364 stars) (3,822 forks)batch import
consider for rtenhancement requesthelp wanted

説明

Description of the new feature / enhancement

Not sure if this is a bug or feature, but I had trouble installing nvm despite uninstalling npm because I forgot I had pnpm installed too, and it left a bunch of crap in C:\Program Files\nodejs folder. So the symlink failed and I was perplexed by nvm use not doing anything...

Suggestion: update readme to mention pnpm?

Suggestion: installer should warn about this? (nodejs existing causing symlink to fail)

Anyway, manually deleting nodejs install folder fixed this. (That's probably not how you should uninstall pnpm, but that's a problem for future me...)

Scenario when this would be used?

Upon installing, so the install actually works...

Supporting information

No response

コントリビューターガイド

技術スタック
nodejsshellgo
領域
documentationcli
Issue 種別
documentation
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
1
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
fresh
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
None
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
90
調査方針
Examine the current README and installer documentation for nvm windows. Add a note about potential conflicts with pnpm, specifically that pnpm may leave files in the Node.js install directory, causing symlink failures for nvm. Consider also adding a troubleshooting step to manually delete the nodejs folder if issues occur. No code changes needed, just documentation updates.