codenotary/immudb

Tests improvements: Better check for errors

オープン

#1,435 opened on 2022/10/26

 (3 件のコメント) (0 件のリアクション) (0 人の担当者)Go (371 件のフォーク)auto 404
enhancementgood first issue

Repository metrics

Stars
 (8,999 個のスター)
PR merge metrics
 (PR metrics pending)

説明

What would you like to be added or enhanced

In many tests we're using require.Error(t, err) which only checks if the error happened without checking if the error is actually expected.

We should add more detailed error check, either by using require.ErrorIs or require.ErrorContains assertions.

Why is this needed

When expecting an error it is necessary to ensure the returned error is what was expected. It may turn out that in some cases the error checked by the test is not what it should be.

コントリビューターガイド