codee-com/open-catalog

[Fortran] Replace `if (integer)` with `if (logical)`

Open

#38 opened on 2024年9月24日

GitHub で見る
 (2 comments) (2 reactions) (0 assignees)Fortran (12 forks)auto 404
Fortrangood first issuenew check

Repository metrics

Stars
 (105 stars)
PR merge metrics
 (PR metrics pending)

説明

In Fortran there is no equivalence between logical and integer variables, so 0 is not a replacement for .false., and 1 does not replace .true.. Yet, some compilers (ifort) will happily compile if (1).

Example:

if (0) write(*, *) 'Test is false'
if (1) write(*, *) 'Test is true'

A slightly more meaningful example

integer val
val = 1
if (val) write(*, *) 'Test is true'

This should be replaced by

integer val
val = 1
if (val > 0) write(*, *) 'Test is true'

コントリビューターガイド