cloudpipe/cloudpickle

0.8.0 3 tests fail

Open

#252 opened on 2019年3月7日

GitHub で見る
 (7 comments) (0 reactions) (0 assignees)Python (1,407 stars) (152 forks)batch import
bughelp wanted

説明

When building cloudpickle 0.8.0 package for openSUSE I have 3 test failures:

[   10s] =================================== FAILURES ===================================
[   10s] ___________ CloudPickleFileTests.test_pickling_special_file_handles ____________
[   10s] 
[   10s] self = <tests.cloudpickle_file_test.CloudPickleFileTests testMethod=test_pickling_special_file_handles>
[   10s] 
[   10s]     def test_pickling_special_file_handles(self):
[   10s]         # Warning: if you want to run your tests with nose, add -s option
[   10s]         for out in sys.stdout, sys.stderr:  # Regression test for SPARK-3415
[   10s] >           self.assertEqual(out, pickle.loads(cloudpickle.dumps(out)))
[   10s] E           AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb6d0> != <_pytest.capture.EncodedFile object at 0x7fc4981be990>
[   10s] 
[   10s] tests/cloudpickle_file_test.py:98: AssertionError
[   10s] __________________ CloudPickleTest.test_pickling_file_handles __________________
[   10s] 
[   10s] self = <tests.cloudpickle_test.CloudPickleTest testMethod=test_pickling_file_handles>
[   10s] 
[   10s]     def test_pickling_file_handles(self):
[   10s]         out1 = sys.stderr
[   10s]         out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[   10s] >       self.assertEqual(out1, out2)
[   10s] E       AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa0ef150>
[   10s] 
[   10s] tests/cloudpickle_test.py:119: AssertionError
[   10s] _____________ Protocol2CloudPickleTest.test_pickling_file_handles ______________
[   10s] 
[   10s] self = <tests.cloudpickle_test.Protocol2CloudPickleTest testMethod=test_pickling_file_handles>
[   10s] 
[   10s]     def test_pickling_file_handles(self):
[   10s]         out1 = sys.stderr
[   10s]         out2 = pickle.loads(cloudpickle.dumps(out1, protocol=self.protocol))
[   10s] >       self.assertEqual(out1, out2)
[   10s] E       AssertionError: <_pytest.capture.EncodedFile object at 0x7fc4acbcb710> != <_pytest.capture.EncodedFile object at 0x7fc4aa179ed0>
[   10s] 
[   10s] tests/cloudpickle_test.py:119: AssertionError

0.7.0 didn't have any issues with these tests. Full build log: cloudpickle.txt

コントリビューターガイド

技術スタック
python
領域
backend
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
Pythonpytestunderstanding of pickle
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
The test failure occurs because pytest replaces sys.stdout and sys.stderr with custom EncodedFile objects during test execution. The tests compare the original and unpickled objects using equality, which fails because the objects are different instances. The fix may involve modifying the test to check for functional equivalence rather than identity, or using a context manager to restore original streams. Look at the test files tests/cloudpickle file test.py and tests/cloudpickle test.py, and consider reviewing the pytest capture mechanism.