cloudflare/boringtun

Keeping timers relative to start of tunnel initiation is confusing

オープン

#309 opened on 2022/08/24

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)Rust (321 件のフォーク)batch import
code qualitygood first issue

Repository metrics

Stars
 (4,849 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Keeping timers this way means that for example update_session_timers takes a time_now param that's a Duration instead of an Instant. All entries in Tunn::timers are Durations when many of them are "the time that something happened" and idiomatically I think these would be better expressed as Instants.

コントリビューターガイド