christophergandrud/networkD3

get back on track with official d3-sankey

Open

#204 opened on 2017年6月19日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)R (565 stars) (257 forks)batch import
help wantedsankeyNetwork

説明

The official d3-sankey library has finally gotten some love recently, it even gained an official horizontal alignment feature. Should we consider getting back to tracking the official version? Frankly, I have avoided messing with any of the sankey code here because so many minor changes/additions have been made I'm afraid of messing something up, but we would likely lose some current features.

Maybe we/someone can audit what we have and compare it to the official library and make a list of additional features we have here, so we can assess the cost of losing them or reimplementing them?

コントリビューターガイド

技術スタック
javascriptr
領域
data
Issue 種別
refactor
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
4
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
3-5 days
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
mostly clear
前提条件
R programmingD3.js basicsnetwork graph concepts
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
20
調査方針
Review the current networkD3 sankey implementation and compare it with the official d3 sankey library (https://github.com/d3/d3 sankey). Identify any custom features added in networkD3 and assess their value. Then decide whether to align with the official version, potentially losing or reimplementing those features. Recommend a plan for integration.