Duplicate Code: URL Launching Logic in AboutPage

Analysis of commit eaf30eabe62f9b178466629c6d3a4c4390e17311

Summary

URL launching logic with identical error handling is duplicated between AboutPage widget and LinkService class. The AboutPage directly implements URL launching instead of using the existing LinkService, leading to code duplication and inconsistent service usage patterns.

Duplication Details

Pattern: Direct URL Launching vs LinkService

• Severity: Medium
• Occurrences: 2 instances
• Locations:
  • lib/ui/pages/about.dart (lines 77-81)
  • lib/services/link.dart (lines 7-11)
• Code Sample:

In lib/ui/pages/about.dart:77-81:

if (await canLaunchUrl(Uri.parse(url!))) {
  await launchUrl(Uri.parse(url));
} else {
  throw 'Could not launch $url';
}

In lib/services/link.dart:7-11:

if (await canLaunchUrlString(link)) {
  await launchUrlString(link);
} else {
  throw 'Could not launch $link';
}

Impact Analysis

• Maintainability: Changes to URL launching logic need to be made in multiple places, increasing the risk of inconsistencies
• Bug Risk: If a bug fix is applied to LinkService, the same bug may still exist in AboutPage unless both locations are updated
• Code Bloat: 11 lines of duplicated logic that could be consolidated
• Inconsistency: Other pages (MorePage, IssueDetailPage) correctly use LinkService.launchLink(), but AboutPage implements its own version

Refactoring Recommendations

1. Refactor AboutPage to use LinkService

   • Update lib/ui/pages/about.dart to use the existing LinkService.launchLink() method
   • Estimated effort: Low complexity (15-30 minutes)
   • Benefits:
     • Eliminates code duplication
     • Ensures consistent URL launching behavior across the app
     • Centralizes error handling in one location
     • Makes AboutPage consistent with other pages (MorePage, IssueDetailPage)

2. Implementation approach:

   • Inject LinkService via Riverpod provider (already available as linkServiceProvider)
   • Replace the inline URL launching logic with ref.read(linkServiceProvider).launchLink(url)
   • Remove the duplicate error handling code

Implementation Checklist

• Review duplication findings
• Update AboutPage to inject and use linkServiceProvider
• Replace inline URL launching logic with LinkService.launchLink() calls
• Verify all contact info links still work correctly
• Ensure consistent error handling across the app
• Run tests to verify no functionality broken

Analysis Metadata

• Analyzed Files: 33 .dart files
• Detection Method: Pattern matching and code structure analysis
• Commit: eaf30eabe62f9b178466629c6d3a4c4390e17311
• Analysis Date: 2026-02-25

AI generated by Duplicate Code Detector

To add this workflow in your repository, run gh aw add github/gh-aw/.github/workflows/duplicate-code-detector.md@94662b1dee8ce96c876ba9f33b3ab8be32de82a4. See usage guide.