chakra-core/ChakraCore

Chakra failed when build with std:c++latest by msvc on Windows

Open

#6,436 opened on 2020年4月23日

GitHub で見る
 (7 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import
Codebase Qualityhelp wanted

説明

Chakra failed when build with std:c++latest by msvc on Windows. Could you please help take a look at this?

You can repro this issue as the steps below:

  1. git clone -c core.autocrlf=true https://github.com/microsoft/ChakraCore D:\Chakra\src
  2. open a clean VS2019 x86 prompt and browse to D:\Chakra\src
  3. set CL=/std:c++latest
  4. msbuild /m /p:Platform=x86 /p:Configuration=Test /p:WindowsTargetPlatformVersion=10.0.18362.0 Build\Chakra.Core.sln /t:Rebuild

Failures: JsrtContextCore.i JsrtContextCore.i(1558483): error C2220: the following warning is treated as an error JsrtContextCore.i(1558483): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored) JsrtContextCore.i(1558485): warning C4499: 'static an explicit specialization cannot have a storage class (ignored) JsrtContextCore.i(1558487): warning C4499: 'static': an explicit specialization cannot have a storage class (ignored)

コントリビューターガイド

技術スタック
cpp
領域
build system
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
2
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
under 1 hour
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C++ basicsMSVC compilermsbuildChakraCore build system
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
40
調査方針
Investigate the warning C4499 reported on lines 1558483-1558487 of JsrtContextCore.i. The fix likely involves adding a pragma to disable the warning around those lines. Check for similar patterns in the codebase. Consider using #pragma warning(push) and #pragma warning(disable: 4499) to suppress the warning for those template specializations. Verify that the fix compiles without errors on Windows with /std:c++latest.