JSRT: JsDeleteIndexedProperty does not tell successful or not · chakra-core/ChakraCore#504

(10 comments) (0 reactions) (0 assignees)JavaScript (9,000 stars) (1,374 forks)batch import

APIsBugSeverity: 3good first issuehelp wanted

説明

JsDeleteIndexedProperty API does not tell if the deletion is successful or not, unlike JsDeleteProperty which returns that info in "result". The former also misses "useStrictRules" flag which exists in the later.

JsDeleteIndexedProperty(JsValueRef object, JsValueRef index)

JsDeleteProperty(JsValueRef object, JsPropertyIdRef propertyId,
                 bool useStrictRules,
                 JsValueRef *result)

These 2 APIs should be comparable and consistent.

コントリビューターガイド

技術スタック: cjavascript
領域: api
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: stale
明確さ: clear
前提条件: C programmingChakraCore API
初心者向け度: 60
調査方針: Look at the implementation of JsDeleteIndexedProperty and JsDeleteProperty in the ChakraCore source, likely in jsrt.cpp. The goal is to add a 'result' parameter and 'useStrictRules' flag to JsDeleteIndexedProperty, and update its call sites to return success status. Check existing tests for the delete property API to understand expected behavior.