cake-build/cake

Tool.Run should make stdout and stderr available on failure

Open

#2,460 opened on 2019年1月24日

GitHub で見る
 (4 comments) (2 reactions) (0 assignees)C# (3,742 stars) (738 forks)batch import
Help wantedImprovementUp-for-grabs

説明

Tool.Run and related should make stdout and stderr available so that some analysis is possible on failure. Currently it calls ProcessExitCode which throws a simple CakeException.

Ideally, it would capture stdout and stderr and throw a CakeProcessException, or similar, that has additional properties for exit code, stdout and stderr.

コントリビューターガイド

技術スタック
csharp
領域
build systemtooling
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C#Cake build system basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
70
調査方針
The request is to modify the Tool.Run method in src/Cake.Core/Tooling/Tool.cs to capture stdout and stderr before throwing an exception. Currently, at line 119, ProcessExitCode is called, and at line 139, a simple CakeException is thrown. The improvement is to create a new exception class CakeProcessException that includes exit code, stdout, and stderr. The implementation should capture the standard output/error from the process. A suggested approach is to use ProcessStartInfo.RedirectStandardOutput and RedirectStandardError before starting the process, then read the output streams before checking the exit code. The new exception should be thrown instead of CakeException. This is a well defined change with concrete file references.
Tool.Run should make stdout and stderr available on failure · cake-build/cake#2460 | Good First Issue