cake-build/cake

CopyFiles does not respect folder structure when pattern only matches files in a subdirectory

Open

#2,102 opened on 2018年3月26日

GitHub で見る
 (2 comments) (1 reaction) (0 assignees)C# (3,742 stars) (738 forks)batch import
BugHelp wantedUp-for-grabs

説明

What You Are Seeing?

CopyFiles does not correctly respect the folder structure when a pattern is used which only matches files in a subdirectory.

What is Expected?

If I have the files: ./src/file1.txt ./src/sub/file2.txt ./src/sub/file3.dat

The command CopyFiles("./src/**/*.txt", "./dest", true) will result in: ./dest/file1.txt ./dest/sub/file2.txt

However the command CopyFiles("./src/**/*.dat", "./dest", true) will result in: ./dest/file3.dat

I would expect it to result in: ./dest/sub/file3.dat

What version of Cake are you using?

0.26.1

Are you running on a 32 or 64 bit system?

64bit

What environment are you running on? Windows? Linux? Mac?

Windows

Are you running on a CI Server? If so, which one?

No

How Did You Get This To Happen? (Steps to Reproduce)

This repo demonstrates the issue: https://github.com/dandezille/cake-copyfiles

Output Log

https://gist.github.com/dandezille/f34f8f0c0fc8429be8fe85397c588856

コントリビューターガイド

技術スタック
csharp
領域
build systemtooling
Issue 種別
bug
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
1-3 hours
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
C# basicsCake build system basics
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
65
調査方針
The bug is in the CopyFiles method. The issue provides a minimal repo (https://github.com/dandezille/cake copyfiles) to reproduce the problem. Examine the implementation of CopyFiles in the Cake source code, specifically how directory structure is preserved when the pattern only matches files in subdirectories. The expected behavior is that the directory hierarchy relative to the source should be maintained in the destination. Check if the issue is in the pattern matching or directory creation logic. Look at existing tests for CopyFiles to understand expected behavior.