Logging discrepancies ? · byt3bl33d3r/CrackMapExec#534

(1 comment) (0 reactions) (0 assignees)Python (7,931 stars) (1,650 forks)batch import

help wanted

説明

Hey there, I was working on the source code of the ldap protocol (cme/protocols/ldap.py) and was wondering why some debug logging is made with self.logger.info and why other is made with logging.debug.

https://github.com/byt3bl33d3r/CrackMapExec/blob/6e57e4c3616b361fa44311389af2bbd7bb12839c/cme/protocols/ldap.py#L509

https://github.com/byt3bl33d3r/CrackMapExec/blob/6e57e4c3616b361fa44311389af2bbd7bb12839c/cme/protocols/ldap.py#L533

Is there a best practice to follow, which one should we use?

コントリビューターガイド

技術スタック: python
領域: developer experience
Issue 種別: research
難度: 1
推定時間: under 1 hour
活動状況: fresh
明確さ: clear
前提条件: Python basics
初心者向け度: 90
調査方針: Examine the usage of self.logger.info vs logging.debug in the ldap.py file at lines 509 and 533. Review other protocol files in cme/protocols to see which logging style is more common. If inconsistent, propose a consistent approach (e.g., use self.logger for all debug logging) and update the file accordingly. The change is localized and should not affect functionality.