bumptech/glide

[Feature request] Improve ViewPropertyTransition.Animator

Open

#2,637 opened on 2017年11月24日

GitHub で見る
 (8 comments) (0 reactions) (0 assignees)Java (35,023 stars) (6,176 forks)batch import
enhancementhelp wanted

説明

Glide Version: 4.3.1

When trying to understand some speed problems on low end devices, I found out that my custom animations where too slow sometimes and left the imageview in transient state too long. Meaning that recyclerview did not recycle the viewholder and created new viewholders everytime.

Fix is easy cancel animations on recycle :) But then trying to do that with current Glide API becomes complicated.

Workaround is to store a reference to viewproperty animator in a tag in the image then call the cancel in the adapter but this is quite ugly :)

I would suggest that ViewPropertyTransition.Animator is extended to have a cancel() or release() interface and have this interface called when clear is called on the target or view recycled

コントリビューターガイド

技術スタック
javaandroid
領域
mobileperformance
Issue 種別
feature
難度新しい貢献者にとっての実装難度です。1 は非常に小さな変更、5 は専門的な作業です。
3
推定時間経験ある貢献者が調査、実装、テスト、pull request 準備にかけるおおよその時間範囲です。
half day
活動状況Issue が今どれだけ取り組みやすいかを示します。新しい、活発、古い、ブロック中、またはメンテナー入力待ちなどです。
stale
明確さ期待される変更、受け入れ条件、次の手順がどれだけ明確かを示します。
clear
前提条件
Android development experienceFamiliarity with Glide's animation API
初心者向け度初回貢献者にどれだけ取り組みやすいかを 1-100 で推定したスコアです。
45
調査方針
The issue requests adding a cancel() or release() method to ViewPropertyTransition.Animator. Start by examining the ViewPropertyTransition class and its Animator interface. Look at how animations are currently handled in Glide's target and request lifecycle. The discussion in the comments may reveal alternate proposals or concerns. Consider how to integrate cancellation with the existing clear() flow on targets.