bodil/purescript-signal

Unnecessary recalculation?

Open

#44 opened on 2016年4月28日

GitHub で見る
 (3 comments) (2 reactions) (0 assignees)PureScript (41 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (260 stars)
PR merge metrics
 (PR metrics pending)

説明

Hi, I'm evaluating several FRP solutions for a large-scale project and have been diving into the source code for this library. First of all, kudos for a great library, it's been working great with the prototypes I've been playing with and I'm greatly enjoying using it.

There's one point I don't understand - in the Elm implementation of FRP, signals pass an 'updated' flag through the signal graph to avoid unnecessary recalculation (see from page 28 in Czaplicki's original paper, and the original implementation of Elm's signals).

However, I can't seem to find this mechanism in the purescript-signal code - the entire signal graph seems to be updated for every input. Is there a reason for this, and would you accept a pull request to add it to the library?

コントリビューターガイド