bitwalker/timex

Most functions are incorrect for calendars other than Calendar.ISO

オープン

#449 opened on 2018/07/30

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Elixir (406 件のフォーク)batch import
feature/enhancementhelp wantedlevel:advanced

Repository metrics

Stars
 (1,807 個のスター)
PR merge metrics
 (30d に merged PR はありません)

説明

Most functions in Timex manipulate the Elixir data structures directly. In doing so, they assume a lot about the underlying calendar - in most cases the functions would just not work for anything other than Calendar.ISO. The prime example would be Timex.shift/2.

Timex should either amend those functions to be correct in case they are called with other calendars, or pattern match on the value and document the functions to only work with Calendar.ISO.

コントリビューターガイド