bazelbuild/bazel

Better bash-less Windows support in actions.run_shell: add command_bat, command_ps

Open

#15,194 opened on 2022年4月7日

GitHub で見る
 (4 comments) (0 reactions) (0 assignees)Java (4,465 forks)batch import
P3good first issuehelp wantedteam-Rules-APItype: feature request

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (平均マージ 22d 20h) (30d で 77 merged PRs)

説明

Description of the feature request:

For better bash-less Windows support,ctx.actions.run_shell could add command_bat (with the same behavior as genrule's cmd_bat) and command_ps (with the same behavior as genrule's cmd_ps).

This would, in particular, considerably simplify skylib's Windows support, where currently we are forced to write and execute temporary .bat files on Windows (and attempt to deal with the ancient terror of argument quoting in .bat interpreter context - take a look at https://stackoverflow.com/questions/4094699/how-does-the-windows-command-interpreter-cmd-exe-parse-scripts if you don't mind losing some points of sanity).

Pinging potentially interested parties: @brandjon @meteorcloudy @alexeagle

コントリビューターガイド