bazelbuild/bazel

Documentation genrule example - maybe avoid $(location ..) or $(locations ..)

Open

#15,078 opened on 2022年3月18日

GitHub で見る
 (0 comments) (0 reactions) (0 assignees)Java (4,465 forks)batch import
P3help wantedteam-Documentationteam-Rules-Servertype: documentation (cleanup)

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (平均マージ 22d 20h) (30d で 77 merged PRs)

説明

Description of the problem / feature request:

https://docs.bazel.build/versions/main/be/general.html#genrule_examples

Elsewhere I've seen that we're not supposed to be using $(location) calls and should instead be using $(rootpath ..) or $(execpath ..)

https://github.com/bazelbuild/bazel/issues/2475#issuecomment-339318016

I just spent hours debugging why a genrule of mine didn't work, when it wasn't exactly clear from the example that

  1. We shouldn't be using $(location ..)
  2. That $(location ..) can return different things in Skylark depending on srcs vs other generated outs.

Maybe this is clear for people who've been in Bazel for years and are aware of the changes to all make-style vars.

コントリビューターガイド