(core): Docker stdout is not printed on error during bundling · aws/aws-cdk#20892

(5 comments) (1 reaction) (0 assignees)TypeScript (10,710 stars) (3,530 forks)batch import

@aws-cdk/assetsbugeffort/smallgood first issuep2package/tools

説明

Describe the bug

In quite a few different scenarios, Docker errors simply happen and "Docker returned 1" gets spat out.

I suspect Docker is writing to stderr but it is getting squashed somewhere.

Expected Behavior

Docker outputs (both stdout and stderr are preserved)

Current Behavior

Docker's error status isn't printed

Reproduction Steps

Run cdk synth on a stack that requires docker, but without permissions to talk to Docker's control plane
watch as it crashes and burns:

39907defbe84: Pull complete
8f7631647f07: Pull complete
d83e11d24ec9: Pull complete
b09b92bf5cf8: Pull complete
[WARNING] 
software.amazon.jsii.JsiiException: docker exited with status 1
Error: docker exited with status 1
    at dockerExec (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/core/lib/bundling.js:355:15)
    at Function.fromBuild (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/core/lib/bundling.js:243:9)
    at new Bundling (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/aws-lambda-python/lib/bundling.js:28:86)
    at Function.bundle (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/aws-lambda-python/lib/bundling.js:43:50)
    at new PythonFunction (/tmp/jsii-kernel-ENBrAx/node_modules/@aws-cdk/aws-lambda-python/lib/function.js:43:39)

The error that is being quashed here was Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Post "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/images/create?fromImage=public.ecr.aws%2Fsam%2Fbuild-python3.7&tag=latest": dial unix /var/run/docker.sock: connect: permission denied

コントリビューターガイド

技術スタック: typescriptnodejsdocker
領域: clouddevops
Issue 種別: bug
難度: 3
推定時間: half day
活動状況: stale
明確さ: clear
前提条件: Familiarity with Node.js child processBasic Docker knowledge
初心者向け度: 60
調査方針: The bug is in the Docker output handling in AWS CDK core. Look at file `packages/@aws cdk/core/lib/bundling.js`, specifically the `dockerExec` function. The issue is that stderr from Docker is not printed on error; only 'docker exited with status 1' is shown. The fix likely involves modifying how child process.execSync or similar captures output. Check comments on the issue for any proposed solutions or maintainer guidance.