`PTH*`: Incorrect suggestion to use `Pathlib` when using file descriptors · astral-sh/ruff#17699

(7 comments) (0 reactions) (0 assignees)Rust (47,527 stars) (2,088 forks)batch import

bugfixeshelp wantedrule

説明

Multiple pathlib rules recommend the use of pathlib.Path over their os equivalent even when they're used with a bytes string or directory descriptor which aren't supported by pathlib.

One such example is

import os
os.listdir(1)

$ ruff --version
ruff 0.11.7
$ ruff check --isolated --select PTH208 t.py
t.py:2:1: PTH208 Use `pathlib.Path.iterdir()` instead.
  |
1 | import os
2 | os.listdir(1)
  | ^^^^^^^^^^ PTH208
  |

Found 1 error.

Past instances of the same or similar error:

コントリビューターガイド

技術スタック: pythonrust
領域: toolingdeveloper experience
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: active
明確さ: clear
前提条件: Pythonpathlibruff rulesfile descriptors
初心者向け度: 65
調査方針: Investigate the implementation of PTH208 in the ruff codebase, likely in `crates/ruff linter/src/rules/pathlib/`. Check how the rule currently determines when to suggest `pathlib.Path.iterdir()`. The issue indicates that the rule should skip cases where the argument is a bytes string or a file descriptor (integer). Review past issues #7620 and #12871 for prior discussion and potential solutions. Implement a condition to suppress the rule when the argument is not a string path.