apache/pinot

Fix logging dependencies in pinot-spi

Open

#6,364 opened on 2020年12月17日

GitHub で見る
 (3 comments) (0 reactions) (0 assignees)Java (1,234 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (4,937 stars)
PR merge metrics
 (平均マージ 6d 7h) (30d で 186 merged PRs)

説明

pinot-spi’s pom has a dependency on log4j-slf4j-impl. I don’t think this is right - it should only depend on slf4j-api. Because of the current dependency, the pinot-java-client’s dependency on pinot-spi pulls in the logging implementation, which is not what you want because it means an external project using the client often needs to exclude those logging jars.

I'm guessing there are other components with a similar issue - only jars that are run from the command line should have dependencies on log4j-slf4j-impl, and include log4j2 configuration resources.

コントリビューターガイド