apache/pinot

Refactor to centralize Job Specification properties for reusability across ingestion jobs

オープン

#14,272 opened on 2024/10/22

 (1 件のコメント) (0 件のリアクション) (1 人の担当者)Java (1,234 件のフォーク)batch import
cleanupgood first issueingestion

Repository metrics

Stars
 (4,937 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Currently some of the the job specification properties are defined at each implementation of batch ingestion like

Hadoop job runner has defined the job spec constants in it's corresponding implementation:

public static final String SEGMENT_GENERATION_JOB_SPEC = "segmentGenerationJobSpec";

// Field names in job spec's executionFrameworkSpec/extraConfigs section private static final String DEPS_JAR_DIR_FIELD = "dependencyJarDir"; private static final String STAGING_DIR_FIELD = "stagingDir";

Similarly spark ingestion runner also defined the same constants in its own classes

private static final Logger LOGGER = LoggerFactory.getLogger(SparkSegmentGenerationJobRunner.class); private static final String DEPS_JAR_DIR = "dependencyJarDir"; private static final String STAGING_DIR = "stagingDir";

Better to centralize them at common place and reuse to avoid deviations in the future.

コントリビューターガイド