apache/openwhisk

"Too many concurrent requests in flight" error message is misleading

オープン

#4,798 opened on 2020/01/12

 (0 件のコメント) (0 件のリアクション) (0 人の担当者)Scala (1,177 件のフォーク)batch import
good first issue

Repository metrics

Stars
 (6,777 個のスター)
PR merge metrics
 (PR metrics pending)

説明

@ali-raza-tariq commented on Fri Jan 10 2020

The existing implementation shows the following error message when inflight limit is exceeded

<Response [429]> b'{\n  "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n  "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'

Few suggestions:

The message is misleading because the allowed should show the existing actionInvokesConcurrent limit set by the user (in this case 1000- which got diluted to 1200-20% increase, because of more than 1 controller in deployment)

So either it should mention allowed per controller, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)

Also, It think it would be better to change the count to something more meaningful like currently running for easy debugging. (good first issue label)

コントリビューターガイド