"Too many concurrent requests in flight" error message is misleading · apache/openwhisk#4798

(0 comments) (0 reactions) (0 assignees)Scala (6,777 stars) (1,177 forks)batch import

good first issue

説明

@ali-raza-tariq commented on Fri Jan 10 2020

The existing implementation shows the following error message when inflight limit is exceeded

<Response [429]> b'{\n  "code": "BWm0N3Qemn4uMAcZWY0JCy8PjTAQ191A",\n  "error": "Too many concurrent requests in flight (count: 240, allowed: 240)."\n}'

Few suggestions:

The message is misleading because the allowed should show the existing actionInvokesConcurrent limit set by the user (in this case 1000- which got diluted to 1200-20% increase, because of more than 1 controller in deployment)

So either it should mention allowed per controller, or simply show the total allowed over all the controllers (in this case, 5 controllers (5*240=1200)

Also, It think it would be better to change the count to something more meaningful like currently running for easy debugging. (good first issue label)

コントリビューターガイド

技術スタック: scala
領域: backend
Issue 種別: bug
難度: 3
推定時間: 1-3 hours
活動状況: fresh
明確さ: mostly clear
前提条件: basic understanding of OpenWhisk architectureScala
初心者向け度: 50
調査方針: The error message is generated in the controller code, likely in the file that handles concurrency limits (e.g., LoadBalancer or ActivationThrottle). The issue suggests changing the 'allowed' field to reflect the user set actionInvokesConcurrent limit or total allowed across controllers. A fix should update the error message string to clarify that the allowed count is per controller, or compute the total allowed. The variable 'allowed' is currently set to the per controller limit; a better approach might be to display both per controller and total limits. Since there are no linked PRs or comments, maintainer input is needed to confirm the desired approach.