apache/openwhisk

WskRestOperation implements action create with copy but it should not

オープン

#3,846 opened on 2018/07/06

 (1 件のコメント) (0 件のリアクション) (0 人の担当者)Scala (1,177 件のフォーク)batch import
help wantedtesting

Repository metrics

Stars
 (6,777 個のスター)
PR merge metrics
 (PR metrics pending)

説明

The copy operation is a function of the cli, not the rest api. So supporting a copy in the WskRestOperation's implementation of wsk.action.create doesn't make sense.

https://github.com/apache/incubator-openwhisk/blob/3ab604c167ac5bec76c756e3e76473863eb0a25d/tests/src/test/scala/common/rest/WskRestOperations.scala#L332

The code should be removed and any rest tests in place should be moved strictly to the cli tests. It's arguable we should preserve this behavior --- if we reify this implementation into a scala SDK for openwhisk. Otherwise, I'm not sure why we should support this.

コントリビューターガイド