apache/openwhisk

WskRestOperation implements action create with copy but it should not

Open

#3,846 opened on 2018年7月6日

GitHub で見る
 (1 comment) (0 reactions) (0 assignees)Scala (6,777 stars) (1,177 forks)batch import
help wantedtesting

説明

The copy operation is a function of the cli, not the rest api. So supporting a copy in the WskRestOperation's implementation of wsk.action.create doesn't make sense.

https://github.com/apache/incubator-openwhisk/blob/3ab604c167ac5bec76c756e3e76473863eb0a25d/tests/src/test/scala/common/rest/WskRestOperations.scala#L332

The code should be removed and any rest tests in place should be moved strictly to the cli tests. It's arguable we should preserve this behavior --- if we reify this implementation into a scala SDK for openwhisk. Otherwise, I'm not sure why we should support this.

コントリビューターガイド

WskRestOperation implements action create with copy but it should not · apache/openwhisk#3846 | Good First Issue