apache/gravitino

[Improvement] Improve validation in SetModelVersionProperty.java

Open

#9,076 opened on 2025年11月11日

GitHub で見る
 (4 comments) (0 reactions) (1 assignee)Java (887 forks)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 stars)
PR merge metrics
 (PR metrics pending)

説明

What would you like to be improved?

Prevent the SetModelVersionProperty CLI command from accepting both an alias and version (or neither), ensuring it fails instead of invoking the server with invalid inputs. Include unit tests, for example:

  @Test
  void validateBothAliasAndVersion() {
    CommandLine mockCmdLine = Mockito.mock(CommandLine.class);
    CommandContext context = new CommandContext(mockCmdLine);

    SetModelVersionProperty command =
        new SetModelVersionProperty(
            context,
            "metalake1",
            "catalog1",
            "schema1",
            "model1",
            1,
            "alias1",
            "prop",
            "value");

   Assertions.assertThrows(RuntimeException.class, command::validate);
  }

How should we improve?

Improve validation and add unit tests, note you'll need to do this Main.useExit = false;.

コントリビューターガイド