apache/gravitino

[Improvement] createTable may return success even when Gravitino metadata persistence fails

オープン

#10,630 opened on 2026/04/01

 (3 件のコメント) (0 件のリアクション) (1 人の担当者)Java (887 件のフォーク)auto 404
good first issueimprovement

Repository metrics

Stars
 (3,058 個のスター)
PR merge metrics
 (PR metrics pending)

説明

What would you like to be improved?

In TableOperationDispatcher.createTable(...), Gravitino first creates the table in the underlying catalog, then writes the TableEntity to the entity store.

If store.put(tableEntity, true) fails, the exception is logged but swallowed, and the method still returns success.

This can leave the external table created, even though Gravitino metadata was not persisted. Clients will receive a successful create-table response even though Gravitino is in an inconsistent state.

Location is TableOperationDispatcher.java (line 640)

How should we improve?

Do not swallow the store.put(...) failure. Propagate the exception so create-table fails instead of returning false success OR if best-effort behavior is intended, return an explicit partial-success/inconsistent-state result and add a test for this path.

Add/modify an existing unit test to check for this.

コントリビューターガイド