apache/airflow

Use Kubernetes-recommended labels for airflow helm chart

オープン

#34,048 opened on 2023/09/03

 (6 件のコメント) (0 件のリアクション) (0 人の担当者)Python (16,781 件のフォーク)batch import
area:helm-chartgood first issuekind:feature

Repository metrics

Stars
 (44,809 個のスター)
PR merge metrics
 (PR metrics pending)

説明

Description

Kubernetes offers a list of recommended labels for grouping resource objects. The prefix app.kubernetes.io differentiates these recommended labels from custom labels.

Why is it needed? Enhancing readability and maintainability

References https://helm.sh/docs/chart_best_practices/labels/#standard-labels https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels

Use case/motivation

https://github.com/apache/airflow/blob/913eff6759bf89d635ef1df1a0db23c157e48c4b/chart/templates/webserver/webserver-deployment.yaml#L36-L40

The above labels would be changed as follows:

app.kubernetes.io/part-of: airflow
app.kubernetes.io/component: webserver
app.kubernetes.io/instance: {{ .Release.Name }}
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
app.kubernetes.io/managed-by: {{ .Release.Service }}

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

コントリビューターガイド