apache/airflow
GitHub で見るDon't have session.commit() when @provide_session decorator is used
Open
#12,818 opened on 2020年12月4日
area:MetaDBcontributors-workshopgood first issuekind:taskpriority:medium
Repository metrics
- Stars
- (44,809 stars)
- PR merge metrics
- (平均マージ 7d 18h) (30d で 834 merged PRs)
説明
As discussed in https://github.com/apache/airflow/pull/12815#discussion_r536283503 and pointed out at https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#database-session-handling, we should not have session.commit() when @provide_session decorator is used (for principle "Explicit is better than implicit").
This issue exists in files like https://github.com/apache/airflow/blob/2936c13a44369daae9d6099cd1070b3a8cd53443/airflow/models/dag.py (and some more of course)